Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testutils: centralization of flags an commands for tests #731

Merged
merged 1 commit into from
Oct 28, 2021
Merged

testutils: centralization of flags an commands for tests #731

merged 1 commit into from
Oct 28, 2021

Conversation

lucasbrunozup
Copy link
Contributor

- What I did
Moved the constants with flags and commands from start_test from testutils directory, to reuse in e2e tests.
- How to verify it
run unit tests and e2e.

Signed-off-by: lucas.bruno lucas.bruno@zup.com.br

@lucasbrunozup lucasbrunozup changed the title testutils: moved the constants with flags and commands from start_tes… testutils: centralization of flags an commands for tests Oct 27, 2021
@lucasbrunozup lucasbrunozup self-assigned this Oct 27, 2021
@lucasbrunozup lucasbrunozup added the kind/improvement This issue is not a Bug nor a Feature label Oct 27, 2021
@lucasbrunozup
Copy link
Contributor Author

lucasbrunozup commented Oct 27, 2021 •
edited
Loading

Would the correct place be in the utils/testutil directory? Or maybe in utils/enums ?

Any suggestions for the filename? I just thought of cliArgs because it contains the commands and flags.
@ZupIT/project-horus-sec-rw

@lucasbrunozup lucasbrunozup force-pushed the feat/cli-args-testutils branch from ded88ea to c3cc397 Compare October 27, 2021 20:49
iancardosozup
iancardosozup reviewed Oct 28, 2021
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@lucasbrunozup lucasbrunozup mentioned this pull request Oct 28, 2021
Merged
@matheusalcantarazup
Copy link
Contributor

Would the correct place be in the utils/testutil directory? Or maybe in utils/enums ?

I think that we can leave in testutil package. The enumns package is very generic and makes the code difficult to read, we need to go to the imports to see which is the "parent" package to know what the enum package means.

@matheusalcantarazup
Copy link
Contributor

Any suggestions for the filename? I just thought of cliArgs because it contains the commands and flags.

I think would be better rename to cli_args to follow the pattern of other files.

matheusalcantarazup added a commit that referenced this pull request Oct 28, 2021
@matheusalcantarazup
tests: fix unnecessary file created on config tests
c017a2f 
Previously when running the config tests a file `config/test` was
created with all the logs. This commit change the behaviour to create
this test log file on temp directory.

This is related with #726 and #731

Signed-off-by: Matheus Alcantara <matheus.alcantara@zup.com.br>
@matheusalcantarazup matheusalcantarazup mentioned this pull request Oct 28, 2021
Merged
matheusalcantarazup added a commit that referenced this pull request Oct 28, 2021
@matheusalcantarazup
tests: fix unnecessary file created on config tests
668d145 
Previously when running the config tests a file `config/test` was
created with all the logs. This commit change the behaviour to create
this test log file on temp directory.

This is related with #726 and #731

Signed-off-by: Matheus Alcantara <matheus.alcantara@zup.com.br>
matheusalcantarazup added a commit that referenced this pull request Oct 28, 2021
@matheusalcantarazup
tests: fix unnecessary file created on config tests
ade8c19 
Previously when running the config tests a file `config/test` was
created with all the logs. This commit change the behaviour to create
this test log file on temp directory.

This is related with #726 and #731

Signed-off-by: Matheus Alcantara <matheus.alcantara@zup.com.br>
matheusalcantarazup added a commit that referenced this pull request Oct 28, 2021
@matheusalcantarazup
tests: fix unnecessary file created on config tests
66e3d9a 
Previously when running the config tests a file `config/test` was
created with all the logs. This commit change the behaviour to create
this test log file on temp directory.

This is related with #726 and #731

Signed-off-by: Matheus Alcantara <matheus.alcantara@zup.com.br>
matheusalcantarazup added a commit that referenced this pull request Oct 28, 2021
@matheusalcantarazup
tests: fix unnecessary file created on config tests (#733)
6419dcf 
Previously when running the config tests a file `config/test` was
created with all the logs. This commit change the behaviour to create
this test log file on temp directory.

This is related with #726 and #731

Signed-off-by: Matheus Alcantara <matheus.alcantara@zup.com.br>
@lucasbrunozup
testutils: moved the constants with flags and commands from start_tes…
3f5d20c 
…t from testutils directory, to reuse in e2e tests.

Signed-off-by: lucas.bruno <lucas.bruno@zup.com.br>
@lucasbrunozup lucasbrunozup force-pushed the feat/cli-args-testutils branch from c3cc397 to 3f5d20c Compare October 28, 2021 13:33
@matheusalcantarazup matheusalcantarazup merged commit 910bde4 into main Oct 28, 2021
@matheusalcantarazup matheusalcantarazup deleted the feat/cli-args-testutils branch October 28, 2021 13:45
@iancardosozup iancardosozup mentioned this pull request Oct 29, 2021
Open
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iancardosozup iancardosozup iancardosozup left review comments

@matheusalcantarazup matheusalcantarazup matheusalcantarazup approved these changes

@nathanmartinszup nathanmartinszup Awaiting requested review from nathanmartinszup

@wiliansilvazup wiliansilvazup Awaiting requested review from wiliansilvazup

Assignees

@lucasbrunozup lucasbrunozup

Labels
kind/improvement This issue is not a Bug nor a Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucasbrunozup @matheusalcantarazup @iancardosozup